View Revisions: Issue #1205

Summary 0001205: Refactor certificate creation routines into /includes/notary.inc.php
Revision 2013-08-20 20:48 by BenBE
Description There is an old idea to dismantle the wot.php and account.php to remove duplicate functionality for certificate signing.

The main reason is, that the routines for certificate creation are mostly identical but have been implemented 4 times:
- Once for User Client certs
- Once for User Server certs
- Once for Org Client certs
- Once for Org Server certs

All those routines are very simular, except for some bits.
This could be centralized to a function with flags.

The starter was Bug 0000790 to add CSR pasting to Org Client certs, a function, that already works for User Client certs and User Server certs, and probably also for Org Server certs.

Another feature request (don't know the bug#), was to add a confirmation page in the create certs process.

By dismantling the certificate creation routines into smaller functions, another workflow level could be easily implemented, e.g. to insert an additional confirmation page into the certificate creation process.

The work in Bug 0000824 was a case study, that pasting a CSR works. But the real hard work never got picked up.

And for Bug 0000440 development in this direction stopped, as SA decided to do a re-development of the CSR extract routine (aka ASN.1)
Revision 2013-08-20 20:48 by BenBE
Description one old idea was to disassemble the wot.php
after that /includes/account.php to disassemble

One main reason is, that the create cert's routine are mostly identical
but have been implemented 4 times
One routine for User Client certs, one for User Server certs, one for Org Client certs, one for Org Server certs.
The routines do all the same, except some bits changes.
This can be centralized to functions with flags

The starter was http://bugs.cacert.org/view.php?id=790
to add CSR pasting to Org Client certs, a function, that still works for user client certs and user server certs, and probably also for Org Server certs.
Another feature request (don't know the bug#), was to add a confirmation page in the create certs process.

By disassembling the certs creation routines into functions, another workflow level can be easily implemented, to also insert a confirmation page into cert's creation the process.

http://bugs.cacert.org/view.php?id=824 work was a case study, that pasting a CSR works. But the real hard work never did gets picked up.

And https://bugs.cacert.org/view.php?id=440 did stop any development in this direction, as SA decided to do a re-development of the CSR extract routine (aka ASN.1)