View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001423 | Main CAcert Website | website content | public | 2017-02-16 09:30 | 2023-09-16 17:24 |
| Reporter | L10N | Assigned To | egal | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Default | OS | any | OS Version | any |
| Summary | 0001423: Link to an Asian Loan Bank | ||||
| Description | On the bottom of cacert.org are some logos with links to this organisations as bit, tunix, nlnet, but also open architecture networtk. The open architecture networtk does not exist anymore and the url is redirected to a loan bank institut in Singapore (https://easycredit.com.sg/moneylenders/). A. The OAN logo should be removed. B. If the bank pays some subsidies to CAcert, the logo should be replaced by their own logo. | ||||
| Tags | No tags attached. | ||||
| Reviewed by | |||||
| Test Instructions | |||||
|
|
I confirm that the link is pointing to a bank, now, which does not seem to have a specific relation to the original project. Further a quick search of mine did not provide any indication that the project continues to be active, but the search was not in depth. Howerver I believe that about adding and removing of sponsors, board should decide. I advise to request for a confirmation that this should be done by board, before such a fix is done. They also should be those who know if it would be correct to remove the link or to let it point to a new destination of the project (or the correct destination of the bank, but I doubt that). |
|
|
I asked board via public mail how the correct solution would look like: a) deleting the complete link, including the logo b) fixing the link to a new location c) changing the link to directly point to that bank, with correct logo (probably not desired) |
|
|
The solution should be: remove the link from the logo. The logo itself can remain for the moment (until board decided how to deal with this logos). |
|
|
This problem could be solved together with 0001440. GuKK Devel, can you do that? I am willing to review. |
|
|
Branch bug-1423 is now merged into the testserver installation and can be tested. Test is quite easy: verify that the Open Architecture Logo ir removed from the bottom of the start page https://test.cacert.org/ Maybe verify that the logo is on no other page. |
|
|
I tested it: 1. Opened https://test.cacert.org/ 2. scrolled down 3. did see 3 logos, but not that one from OpenArchitecture. -> OK |
|
|
opened test.cacert.org got the main page with logo of openarchitecture not shown. looks as expected --> OK |
|
|
Minimum test reports are reached (which should be enough for such a simple change, but don't hesitate to post your report nevertheless!), so I'm putting this in status "needs review"... |
|
|
I completely forgot that I had already tested it and did it again in code on behalf of whatever: - replaced the link from OpenArchitecture - added another logo (Cacert) with Link to our wiki page with the smaller sponsors /includes/sponsorinfo.php |
|
|
I completely forgot that I had already tested it and did it again in code on behalf of egal: - removed the broken link from OAN - ad another Logo (CAcert) with link to the wikipage with other sponsors /includes/sponsorinfo.php |
|
|
Egal asked me to do that (and I didn't remember, that it was already done and I was one of the reviewers). In the attached code is a difference: - broken link removed (similar) - new CAcert logo added with link to wiki sponsor page /includes/sponsorifno.php |
|
|
Egal asked me to do that (and I didn't remember, that it was already done and I was one of the reviewers). In the attached code is a difference: - broken link removed (similar) - new CAcert logo added with link to wiki sponsor page /includes/sponsorifno.php sponsorinfo.php (744 bytes)
<div class="sponsorinfo">
<?=_("CAcert operations are sponsored by")?>
<a href="http://www.bit.nl/" target="_blank"><img class="sponsorlogo" src="/images/bit.png" alt="[BIT logo]" border="0"></a>
<a href="http://www.tunix.nl/" target="_blank"><img class="sponsorlogo" src="/images/tunix.png" alt="[TUNIX logo]" border="0"></a>
<a href="http://www.nlnet.nl/" target="_blank"><img class="sponsorlogo" src="/images/nlnet.png" alt="[NLnet logo]" border="0"></a>
<img class="sponsorlogo" src="/images/oan.png" alt="[OAN logo]" border="0"></a>
<a href="http://wiki.cacert.org/FAQ/AboutUs/History#Sponsors" target="_blank"><img class="sponsorlogo" src="/images/cacert4.png" alt="[OAN logo]" border="0"></a>
</div>
|
|
|
sponsorinfo on testserver is different to the attached one: <img class="sponsorlogo" src="/images/oan.png" alt="[OAN logo]" border="0"></a> <a href="http://wiki.cacert.org/FAQ/AboutUs/History#Sponsors" target="_blank"><img class="sponsorlogo" src="/images/cacert4.png" alt="[OAN logo]" border="0"></a> To fix: OAN-Image shold be removed, too Sponsor-Logo for the link to wiki should not be CAcert (maybe completely remove the image and add "more" (or another text) for the link) If an Image should be kept, please adjust the alt-text |
|
|
Created a pull request https://code.cacert.org/cacert/cacert-webdb/pulls/7 that removes the OAN and Tunix links (similar to the change in https://bugs.cacert.org/view.php?id=1423#c5907) |
|
|
reviewed in PR by egal |
|
|
rolled out on webdb |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-02-16 09:30 | L10N | New Issue | |
| 2017-03-10 18:18 | Eva | Note Added: 0005540 | |
| 2017-03-10 18:43 | Eva | Note Added: 0005541 | |
| 2018-11-06 00:05 | L10N | Note Added: 0005657 | |
| 2018-11-06 00:06 | L10N | Note Added: 0005658 | |
| 2018-11-06 10:45 | GuKKDevel | Assigned To | => GuKKDevel |
| 2018-11-06 10:54 | GuKKDevel | Status | new => needs review & testing |
| 2018-11-06 10:56 | GuKKDevel | Severity | major => trivial |
| 2018-11-06 10:57 | GuKKDevel | Relationship added | related to 0001440 |
| 2019-09-26 20:43 | Ted | Note Added: 0005846 | |
| 2019-09-26 22:26 | L10N | Note Added: 0005847 | |
| 2019-09-27 09:28 | GuKKDevel | Note Added: 0005848 | |
| 2019-10-02 19:28 | Ted | Assigned To | GuKKDevel => Ted |
| 2019-10-02 19:28 | Ted | Status | needs review & testing => needs review |
| 2019-10-02 19:28 | Ted | Note Added: 0005850 | |
| 2020-08-10 12:23 | L10N | Note Added: 0005904 | |
| 2020-08-10 12:31 | L10N | Note Added: 0005905 | |
| 2020-08-10 12:51 | L10N | Note Added: 0005906 | |
| 2020-08-10 14:17 | L10N | Note Added: 0005907 | |
| 2020-08-10 14:17 | L10N | File Added: sponsorinfo.php | |
| 2021-04-05 17:31 | egal | Note Added: 0005972 | |
| 2023-09-16 14:26 | jandd | Note Added: 0006191 | |
| 2023-09-16 17:15 | jandd | Assigned To | Ted => egal |
| 2023-09-16 17:15 | jandd | Status | needs review => ready to deploy |
| 2023-09-16 17:15 | jandd | Note Added: 0006192 | |
| 2023-09-16 17:24 | jandd | Status | ready to deploy => solved? |
| 2023-09-16 17:24 | jandd | Resolution | open => fixed |
| 2023-09-16 17:24 | jandd | Note Added: 0006193 | |
| 2023-09-16 17:24 | jandd | Status | solved? => closed |
