View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001298 | Main CAcert Website | source code | public | 2014-08-07 15:56 | 2014-12-02 22:48 |
| Reporter | wytze | Assigned To | BenBE | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2014 Q2 | ||||
| Target Version | 2014 Q3 | Fixed in Version | 2014 Q3 | ||
| Summary | 0001298: CommModule code requires a trivial change to run with Debian Wheezy | ||||
| Description | The CAcert CommModule code requires a trivial change to run with Debian Wheezy. The code is using "use Digest::SHA1 qw(sha1_hex);". The Perl module used here has been renamed in Debian Wheezy to Digest::SHA. | ||||
| Steps To Reproduce | Upgrade operating system to Debian Wheezy and run CommModule client. Both cacert1.it-sls.de and cacert2.it-sls.de have been upgraded, and can be used to observe the problem. | ||||
| Additional Information | The trivial patch for this problem is: --- /home/cacert/www/CommModule/client.pl.org 2014-06-07 11:23:52.000000000 +0200 +++ /home/cacert/www/CommModule/client.pl 2014-06-20 17:19:38.115732719 +0200 @@ -31,7 +31,7 @@ use Locale::gettext; use IO::Socket; use MIME::Base64; -use Digest::SHA1 qw(sha1_hex); +use Digest::SHA qw(sha1_hex); #Protocol version: my $ver=1; | ||||
| Tags | No tags attached. | ||||
| Reviewed by | Ted, BenBE | ||||
| Test Instructions | |||||
|
|
I looked over the proposed patch and created a git commit from it: https://github.com/yellowant/cacert-devel/commits/bug-1298 |
|
|
Applied on testserver, but needs a rebuilt of the chroot to be fully working. |
|
|
The chroot on test.cacert.org aka cacert1.it-sls.de has been rebuilt to Debian Wheezy on August 9, 2014 around 12:00 CEST. |
|
|
Test result on cacert1.it-sls.de: CommModule client is starting and running correctly. |
|
|
Please note that the signing server simulation running on the test servers from server.pl requires the same patch as the CommModule client.pl in order to start and operate correctly on Debian Wheezy. This patch cannot and will not be applied to the production signing server until (if ever) it is upgraded to Debian Wheezy. |
|
|
Reviewed commit fa3a17789986431c15dac26c43a8100ee7e8d0d4 vs. 4c250123ec16e7c14b06fad3de4313243800a31f Only change is the different module include in client.pl as in "Additional Information". client.pl only uses sha1_hex from the module, calling convention between the different versions is compatible (see http://search.cpan.org/~gaas/Digest-SHA1-2.13/SHA1.pm and http://search.cpan.org/~mshelor/Digest-SHA-5.92/lib/Digest/SHA.pm). No tests on the different OS versions were made. Review is PASSED, comment #0004932 applies. |
|
|
The fix has been installed on the production server on August 21, 2014. See also: https://lists.cacert.org/wws/arc/cacert-systemlog/2014-08/msg00014.html |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-08-07 15:56 | wytze | New Issue | |
| 2014-08-08 16:53 | BenBE | Assigned To | => felixd |
| 2014-08-08 16:53 | BenBE | Status | new => needs work |
| 2014-08-08 23:35 | felixd | Note Added: 0004924 | |
| 2014-08-08 23:55 | BenBE | Source_changeset_attached | => cacert-devel testserver-stable 3622a002 |
| 2014-08-08 23:55 | felixd | Source_changeset_attached | => cacert-devel testserver-stable 4c250123 |
| 2014-08-09 00:12 | BenBE | Reviewed by | => BenBE |
| 2014-08-09 00:12 | BenBE | Note Added: 0004927 | |
| 2014-08-09 00:12 | BenBE | Assigned To | felixd => NEOatNHNG |
| 2014-08-09 00:12 | BenBE | Status | needs work => needs review & testing |
| 2014-08-09 10:08 | wytze | Note Added: 0004929 | |
| 2014-08-09 10:10 | wytze | Note Added: 0004931 | |
| 2014-08-09 10:13 | wytze | Note Added: 0004932 | |
| 2014-08-15 18:17 | Ted | Note Added: 0004944 | |
| 2014-08-15 18:17 | Ted | Reviewed by | BenBE => Ted, BenBE |
| 2014-08-15 18:17 | Ted | Status | needs review & testing => needs testing |
| 2014-08-18 05:36 | BenBE | Assigned To | NEOatNHNG => BenBE |
| 2014-08-18 05:36 | BenBE | Status | needs testing => ready to deploy |
| 2014-08-21 15:12 | wytze | Note Added: 0004980 | |
| 2014-08-21 15:12 | wytze | Status | ready to deploy => solved? |
| 2014-08-21 15:12 | wytze | Fixed in Version | => 2014 Q3 |
| 2014-08-21 15:12 | wytze | Resolution | open => fixed |
| 2014-08-28 07:25 | BenBE | Source_changeset_attached | => cacert-devel release 113e6152 |
| 2014-12-02 22:48 | INOPIAE | Status | solved? => closed |
