View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001343 | Main CAcert Website | source code | public | 2014-12-13 11:46 | 2016-02-26 19:44 |
| Reporter | wytze | Assigned To | NEOatNHNG | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | ready to deploy | Resolution | open | ||
| Platform | Main CAcert Website | OS | N/A | OS Version | stable |
| Product Version | 2014 Q4 | ||||
| Target Version | 2014 Q4 | Fixed in Version | 2015 Q3 | ||
| Summary | 0001343: CommModule server.pl does not respond correctly to start/stop commands | ||||
| Description | The CAcert CommModule server.pl code requires a minor fix to respond correctly to the "service commmodule stop" command. The current code does not properly take Perl operator priority into account. | ||||
| Steps To Reproduce | Try to stop the running signing server (server.pl process) with: service commmodule stop (NOTE: on the test servers: service commmodule-signer stop). Observe that the server.pl process continues running. | ||||
| Additional Information | Context diff for the source code fix is: @@ -1002,7 +1002,7 @@ my $count=0; #As soon as the client connected successfully, the client has to send a request faster than every 10 seconds -while(@ready = $sel->can_read(15) && -f "./server.pl-active") +while((@ready = $sel->can_read(15)) && -f "./server.pl-active") { my $data=""; #my $length=read SER,$data,1; | ||||
| Tags | No tags attached. | ||||
| Reviewed by | NEOatNHNG, BenBE | ||||
| Test Instructions | See Steps to Reproduce | ||||
|
|
Tested by Crit (wytze) when providing the original patch. Also tested by me when restarting the CommModule recently when I applied patches on the testserver. |
|
|
Patch looks OK, although I'm not Perl-literate enough to get why it was not working before. Yes, the @ready would contain a different value, but shouldn't that be false too if the server.pl-active is missing? |
|
|
Tested on a local installation: The Signer seems to behave identically with or without the brackets. In both cases the perl command terminated within 20 seconds. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-13 11:46 | wytze | New Issue | |
| 2014-12-13 13:11 | BenBE | Assigned To | => BenBE |
| 2014-12-13 13:11 | BenBE | Status | new => fix available |
| 2014-12-13 13:11 | BenBE | Target Version | => 2014 Q4 |
| 2014-12-13 19:35 | BenBE | Source_changeset_attached | => cacert-devel testserver-stable ee87b973 |
| 2014-12-13 19:35 | BenBE | Source_changeset_attached | => cacert-devel testserver-stable feea340c |
| 2014-12-13 19:35 | BenBE | Reviewed by | => BenBE |
| 2014-12-13 19:35 | BenBE | Assigned To | BenBE => NEOatNHNG |
| 2014-12-13 19:35 | BenBE | Status | fix available => needs review & testing |
| 2015-03-03 20:40 | BenBE | Note Added: 0005340 | |
| 2015-07-29 17:02 | NEOatNHNG | Reviewed by | BenBE => NEOatNHNG, BenBE |
| 2015-07-29 17:02 | NEOatNHNG | Note Added: 0005442 | |
| 2015-07-29 17:02 | NEOatNHNG | Status | needs review & testing => needs testing |
| 2015-08-25 20:22 | felixd | Note Added: 0005457 | |
| 2016-02-26 19:44 | BenBE | Status | needs testing => ready to deploy |
| 2016-02-26 19:44 | BenBE | Fixed in Version | => 2015 Q3 |
