View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000147 | Main CAcert Website | website content | public | 2006-03-04 12:09 | 2013-01-13 17:01 |
Reporter | aanriot | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Fixed in Version | 2006 | ||||
Summary | 0000147: useless $key = $val | ||||
Description | In some source files I find the following lines: foreach($_REQUEST as $key => $val) $key = $val; This will set the variable $key so a number of different values but doesn't do anything useful. I guess it is a try to simulate extract() ... | ||||
Tags | No tags attached. | ||||
Reviewed by | |||||
Test Instructions | |||||
|
It was a quick hack when globals was turned off... The second line should have been: $$key = $val; These lines have now been removed. Ideally the code should be fixed so that globals can be removed without harming anything and without needing hacks like these... |
Date Modified | Username | Field | Change |
---|---|---|---|
2006-03-04 12:09 |
|
New Issue | |
2006-08-16 13:59 | duane | Status | new => needs work |
2006-08-16 13:59 | duane | Assigned To | => bluec |
2006-08-16 14:01 | duane | Status | needs work => solved? |
2006-08-16 14:01 | duane | Fixed in Version | => production |
2006-08-16 14:01 | duane | Resolution | open => fixed |
2006-08-16 14:01 | duane | Note Added: 0000526 | |
2007-10-24 06:07 | evaldo | Reporter | bluec => aanriot |
2007-10-24 06:07 | evaldo | Assigned To | bluec => |
2007-10-24 06:07 | evaldo | Status | solved? => closed |
2013-01-13 17:01 | Werner Dworak | Fixed in Version | => 2006 |