View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000167 | Main CAcert Website | web of trust | public | 2006-03-08 07:30 | 2013-01-14 01:30 |
Reporter | sglaser | Assigned To | Sourcerer | ||
Priority | normal | Severity | trivial | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Fixed in Version | 2006 | ||||
Summary | 0000167: No points might be added because the member already has got 35 points | ||||
Description | While assuring a member with 35 points already allocated by someone else, I received a warning that the system might round down my 10 points or even assign no new points at all because of the aforesaid 35 points. If I didn't get something wrong this message should only appear if the sum of the points I can allocate at most together with the points already allocated exceeds 100. | ||||
Additional Information | - I was using German as my default language. - My maximum of 10 points was correctly and immediately allocated. | ||||
Tags | No tags attached. | ||||
Reviewed by | |||||
Test Instructions | |||||
|
- if($_SESSION['_config']['pointsalready'] > 0) + if(100 - $_SESSION['_config']['pointsalready'] - maxpoints() <= 0) |
|
Sorry, but this doesn´t solve the issue correctly. + if(100 - $_SESSION['_config']['pointsalready'] - maxpoints() <= 0) 1. Super Assurers can issue up to 150 points, so the hardcoded value 100 is definitely wrong. 2. The error message says that the user already has points. Your IF statement triggers also when the user does not have any points. I think the statement should look something like this: + if(($_SESSION['_config']['pointsalready']>0) && (maxmaxpoints() - $_SESSION['_config']['pointsalready'] - maxpoints() <= 0)) |
|
Fixed. |
|
Yes, looks fixed to me. |
Date Modified | Username | Field | Change |
---|---|---|---|
2006-03-08 07:30 | sglaser | New Issue | |
2006-08-16 09:08 | duane | Status | new => solved? |
2006-08-16 09:08 | duane | Resolution | open => fixed |
2006-08-16 09:08 | duane | Assigned To | => duane |
2006-08-16 09:08 | duane | Note Added: 0000516 | |
2006-08-16 09:08 | duane | Note Edited: 0000516 | |
2006-08-23 23:14 | Sourcerer | Note Added: 0000632 | |
2006-08-23 23:14 | Sourcerer | Status | solved? => @30@ |
2006-09-06 12:14 | duane | Status | @30@ => needs work |
2006-09-06 12:14 | duane | Assigned To | duane => Sourcerer |
2006-09-06 12:14 | duane | Status | needs work => solved? |
2006-09-06 12:14 | duane | Fixed in Version | => production |
2006-09-06 12:14 | duane | Note Added: 0000663 | |
2006-09-06 21:57 | Sourcerer | Status | solved? => closed |
2006-09-06 21:57 | Sourcerer | Note Added: 0000667 | |
2013-01-14 01:30 | Werner Dworak | Fixed in Version | => 2006 |