View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000789Main CAcert Websiteorganisational sectionpublic2009-11-13 02:342013-01-15 14:25
Reporterlaw Assigned ToNEOatNHNG  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Fixed in Version2012 Q3 
Summary0000789: Editing domain for organisations does not work
DescriptionWhen editing a domain for an organisation it does not work. The domain field is blank afterwards.
TagsNo tags attached.
Attached Files
29.php (1,994 bytes)
account-diff-20110926.php (2,553 bytes)
Reviewed bydastrath, NEOatNHNG
Test Instructions

Relationships

has duplicate 0000880 closedINOPIAE test.cacert.org When changing the domain name for an organization domain the name gets lost 

Activities

Uli60

2011-09-01 09:47

updater   ~0002392

editing domain
eg https://<website>/account.php?id=29&orgid=233&domid=746
add new xyz form needs reset of session vars
editing of xyz forms needs readin of session vars with pre-filling fields

29.php domain is pre-filled with
line 24 -> $_SESSION['_config']['domain'] = $row['domain'];
and
line 35 -> value="<?=sanitizeHTML($_SESSION['_config']['domain'])?>">

script continues with:
a) type="submit" name="process" value="<?=_("Update")?>">
b) name="oldid" value="<?=intval($id)?> -> 29
c) name="orgid" value="<?=intval($_REQUEST['orgid'])?>"> -> existing orgid
d) name="domainname" value="<?=sanitizeHTML($_SESSION['_config']['domain'])?>"> -> domain name

/includes/account.php processes
oldid=29, orgid=<orgid>, process="update"
approx line 2139: oldid==29 && process!=""
  line 2141: $domainname -> where does $domainname come from ?!?
  line 2143: request of $_SESSION['_config']['domid'])

  line 2147: setting $_SESSION['_config']['errmsg']
   -> The domain '%s' is already in a different account and is listed as valid. Can't continue.
    => reset id=29, oldid=0

returns to 29.php
 domid is NOT set !!! (debugged)
 orgid is set

/includes/account.php if oldid=29 section (l. 0000841:0002143)
  reset domid to its original state with
  $domid = $_SESSION['_config']['domid']) AND
  $_REQUEST['domid'] = $domid;

Uli60

2011-09-01 09:51

updater   ~0002393

added
/includes/account.php fix
+ added Cancel button in 29.php form
/pages/account/29.php

on error message, with the cancel button pressed the user returns to default website page

Uli60

2011-09-15 15:43

updater   ~0002443

login as OrgAssurer
OrgAssurer - View Organisations - Domains
links to -> eg https://<>/account.php?id=26&orgid=234
then edit
links to -> eg https://<>/account.php?id=29&orgid=234&domid=744
so bug#880 is a dupe of bug#789

Ted

2011-09-18 21:42

administrator   ~0002462

Created git branch bug-789, merged into master and installed on testserver

illuminat

2011-09-22 19:41

reporter   ~0002485

Cancel button works as intended and forwards to main page.

Editing domain does not work. Seems so try to edit into an empty string.
Error message in german as follows:

Die Domain '' ist bereits in einem anderen Konto und als gültig aufgelistet. Fortsetzen nicht möglich.

Uli60

2011-09-26 11:40

updater   ~0002522

login to orgadmin (orgadmin flag not set)
OrgAssurer - View (only) lists only available domains.
no edit domain function at all enabled.

Uli60

2011-09-26 15:19

updater   ~0002523

login as org assurer (orgadmin flag set)
Org Assurer - View Organisations
click on one domains(1) link
https://cacert1.it-sls.de/account.php?id=26&orgid=266
opens one domain line
this.domain Edit Delete
clicking edit
https://cacert1.it-sls.de/account.php?id=29&orgid=266&domid=773
editing domain from eg. test.domain to new.domain
results in:
The domain '' is already in a different account and is listed as valid. Can't continue.

this isn't the sent fix :-P

cancel - returns to main page
=> ok

checking cacert-devel repository
/pages/account/29.php is identical
/includes/account.php is total different to the patch revision
                      maybe another patch breaks 0000789 fix

new patch applied onto
current /includes/account.php revision from 4aacf8c..1fe6916
line 2283 ff.

Uli60

2011-09-26 15:21

updater   ~0002524

checking cacert-devel repository
/pages/account/29.php is identical
/includes/account.php is total different to the patch revision
                      maybe another patch breaks 0000789 fix

new patch applied onto
current /includes/account.php revision from 4aacf8c..1fe6916
line 2283 ff.
3 blocks, 2 lines changed

Ted

2011-09-26 21:56

administrator   ~0002526

Tried to add the changes once again, please check if it worked this time

Uli60

2011-09-26 22:12

updater   ~0002527

login orgassurer
Org Assurer - View Orgs
selecting Domains(1) of one org
eg foobar
edit foobar.org -> newbar.org
cancel -> returns to main page
=> ok

Org Assurer - View Orgs
selecting Domains(1) of one org
eg foobar
edit foobar.org -> newbar.org
update -> confirm update
changes domain, lists newbar.org as new domain
=> ok

edit newbar.org -> foobar.org
update -> confirm update
changes domain, lists foobar.org as new domain
=> ok

patch now works again as expected

INOPIAE

2011-09-27 08:47

updater   ~0002530

login as orgassurer
Org Assurer - View Orgs
selecting domain of one org
edit domain
cancel -> returns to main page
=> ok

Org Assurer - View Orgs
edit domain
update -> confirm update
changes domain, lists the changed information for the domain
=> ok

Uli60

2011-09-27 18:45

updater   ~0002537

tested by 2, test finished
needs 2nd review + deploy

NEOatNHNG

2011-11-15 23:22

administrator   ~0002692

Reviewed but had some issues so I fixed it (don't use $_SESSION as it breaks multiple tabs and such). Please review and test.

INOPIAE

2011-11-19 09:29

updater   ~0002707

Open two tabs to added a domain to an organisation (account.php?id=26) with two different organisations.
Adding a domain for org1 works
following the link on the result page I get back to the list of domains of org1
new domain is listed for org1
=> ok

Change to tab of org2
Adding a domain for org2 works
following the link on the result page I get back to the list of domains of org2
new domain is listed for org2
=> ok

Adding a blank domain gives an error message => ok

JensK

2011-12-11 13:17

reporter   ~0002741

Opened two organizations in two different tabs.

Changed domain of organization1: New domain listed properly => OK
Changed domain of organization2 in other tab: New domain listed properly => OK
In the first tab, tried to change domain of organization1 to the domain listed for organization 2: "The domain 'foobar.de' is already in a different account and is listed as valid. Can't continue." => OK
Tried to change domain of organization1 to an empty string: "The domain '' is already in a different account and is listed as valid. Can't continue." => Error is correct, but shoudn't the message be different?
Tried to edit a domain, then clicked cancel: Returns to main page without changing anything => OK

INOPIAE

2012-01-10 22:17

updater   ~0002774

Open two tabs to added a domain to an organisation (account.php?id=26) with two different organisations.
Adding a domain for org1 works
following the link on the result page I get back to the list of domains of org1
new domain is listed for org1
=> ok

Change to tab of org2
Adding a domain for org2 works
following the link on the result page I get back to the list of domains of org2
new domain is listed for org2
=> ok

Adding a blank domain gives an error message => ok

Uli60

2012-01-11 00:47

updater   ~0002776

tested by 2, needs 2nd review + deployment to critical system

Uli60

2012-07-24 23:26

updater   ~0003109

2nd review done by dirk within
https://wiki.cacert.org/Software/Assessment/20120724-S-A-MiniTOP

Uli60

2012-07-24 23:28

updater   ~0003110

tested by 2: inopiae, JensK
2nd review done by dirk within telco 2012-07-24
ready to go

NEOatNHNG

2012-07-25 00:23

administrator   ~0003111

Mail sent to critical admins.

wytze

2012-07-25 15:23

developer   ~0003115

The fix has been installed on the production server on July 25, 2012. See also:
https://lists.cacert.org/wws/arc/cacert-systemlog/2012-07/msg00007.html

Werner Dworak

2012-12-21 04:54

updater   ~0003503

More than 3 month fixed and no complaints

Issue History

Date Modified Username Field Change
2009-11-13 02:34 law New Issue
2011-09-01 09:46 Uli60 Assigned To => Uli60
2011-09-01 09:47 Uli60 Note Added: 0002392
2011-09-01 09:47 Uli60 Status new => needs work
2011-09-01 09:48 Uli60 File Added: account.php
2011-09-01 09:49 Uli60 File Added: 29.php
2011-09-01 09:51 Uli60 Note Added: 0002393
2011-09-01 09:51 Uli60 Status needs work => fix available
2011-09-15 15:35 Uli60 Relationship added related to 0000880
2011-09-15 15:43 Uli60 Note Added: 0002443
2011-09-15 15:44 Uli60 Relationship replaced has duplicate 0000880
2011-09-18 21:32 Ted Assigned To Uli60 => Ted
2011-09-18 21:42 Ted Note Added: 0002462
2011-09-18 21:42 Ted Assigned To Ted => Uli60
2011-09-18 21:42 Ted Status fix available => needs review & testing
2011-09-18 21:45 Ted Source_changeset_attached => cacert-devel master df29ee21
2011-09-22 19:41 illuminat Note Added: 0002485
2011-09-22 19:41 illuminat Status needs review & testing => needs work
2011-09-26 11:40 Uli60 Note Added: 0002522
2011-09-26 15:19 Uli60 Note Added: 0002523
2011-09-26 15:20 Uli60 File Added: account-diff-20110926.php
2011-09-26 15:20 Uli60 File Deleted: account.php
2011-09-26 15:21 Uli60 Note Added: 0002524
2011-09-26 15:21 Uli60 Status needs work => fix available
2011-09-26 21:50 Ted Source_changeset_attached => cacert-devel master 06397504
2011-09-26 21:56 Ted Note Added: 0002526
2011-09-26 21:56 Ted Status fix available => needs review & testing
2011-09-26 22:12 Uli60 Note Added: 0002527
2011-09-27 08:47 INOPIAE Note Added: 0002530
2011-09-27 18:45 Uli60 Note Added: 0002537
2011-09-27 18:45 Uli60 Status needs review & testing => ready to deploy
2011-09-27 23:12 NEOatNHNG Source_changeset_attached => cacert-devel testserver 43823ab4
2011-10-20 18:19 NEOatNHNG Assigned To Uli60 => NEOatNHNG
2011-11-15 23:20 NEOatNHNG Source_changeset_attached => cacert-devel testserver d5b5b11d
2011-11-15 23:20 NEOatNHNG Source_changeset_attached => cacert-devel testserver a0c88feb
2011-11-15 23:22 NEOatNHNG Note Added: 0002692
2011-11-15 23:22 NEOatNHNG Status ready to deploy => needs review & testing
2011-11-15 23:26 NEOatNHNG Reviewed by => NEOatNHNG
2011-11-19 09:29 INOPIAE Note Added: 0002707
2011-11-24 17:20 NEOatNHNG Source_changeset_attached => cacert-devel testserver e88ecfb9
2011-11-24 17:20 NEOatNHNG Source_changeset_attached => cacert-devel testserver 9875ded5
2011-12-11 13:17 JensK Note Added: 0002741
2012-01-10 22:17 INOPIAE Note Added: 0002774
2012-01-11 00:47 Uli60 Note Added: 0002776
2012-01-11 00:47 Uli60 Assigned To NEOatNHNG =>
2012-01-11 00:47 Uli60 Status needs review & testing => needs review
2012-07-24 23:26 Uli60 Note Added: 0003109
2012-07-24 23:28 Uli60 Note Added: 0003110
2012-07-24 23:28 Uli60 Assigned To => NEOatNHNG
2012-07-24 23:28 Uli60 Status needs review => ready to deploy
2012-07-25 00:23 NEOatNHNG Reviewed by NEOatNHNG => dastrath, NEOatNHNG
2012-07-25 00:23 NEOatNHNG Note Added: 0003111
2012-07-25 00:30 NEOatNHNG Source_changeset_attached => cacert-devel release b4e46cf7
2012-07-25 15:23 wytze Note Added: 0003115
2012-07-25 15:23 wytze Status ready to deploy => solved?
2012-07-25 15:23 wytze Resolution open => fixed
2012-12-21 04:54 Werner Dworak Note Added: 0003503
2012-12-21 04:54 Werner Dworak Status solved? => closed
2013-01-15 14:25 Werner Dworak Fixed in Version => 2012 Q3