View Issue Details

IDProjectCategoryView StatusLast Update
0000819Main CAcert Websitesource codepublic2013-01-15 14:36
ReporterNEOatNHNG Assigned ToNEOatNHNG  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Fixed in Version2011 Q3 
Summary0000819: Comparison instead of Assignment
There is a comparison but the result of the comparison is never used. The code structure indicates this should actually be an assignment.

On the other hand this value is never used (if conditions prevent this code from executing when the usage would be executed)

It could also be argued that the value shouldn't be set to 'Administrative Increase' but to 'Temporary Increase' as in line 291
Additional InformationPossible fixes:
a) remove the line -> keep the current (maybe unintended) functionality of the code

b) change the comparison to an assignment -> functionality changes

Option b) is contained in e12e8f2e37d1b193b5dfa7b678ed83fe96df969b at git://

For testing testers would have to have the board flag set and should assign temporary points to someone, but even then it's hard to test whether there aren't any side effects anywhere in the code.
TagsNo tags attached.
Reviewed by
Test Instructions


related to 0001134 closedNEOatNHNG Delete the board flag thourougly in all parts of our software 



2010-05-04 19:59

administrator   ~0001585

I am quite sure that it should be an assignment.
But since super-assurance is stopped, the whole board-flag and all that code is practically not needed anymore.


2011-09-01 09:59

updater   ~0002395

code has been fixed back in 2010
as a starter for testing the software update cycle

Issue History

Date Modified Username Field Change
2010-05-04 12:51 NEOatNHNG New Issue
2010-05-04 19:59 Sourcerer Note Added: 0001585
2011-09-01 09:59 Uli60 Note Added: 0002395
2011-09-01 09:59 Uli60 Status new => solved?
2011-09-01 09:59 Uli60 Resolution open => fixed
2011-09-01 09:59 Uli60 Assigned To => NEOatNHNG
2011-09-02 00:29 NEOatNHNG Status solved? => closed
2013-01-09 04:31 Werner Dworak Relationship added related to 0001134
2013-01-15 14:36 Werner Dworak Fixed in Version => 2011 Q3