View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000999 | Main CAcert Website | account administration | public | 2011-12-03 04:57 | 2013-09-24 19:15 |
| Reporter | INOPIAE | Assigned To | egal | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 2011 Q4 | ||||
| Target Version | 2013 Q2 | Fixed in Version | 2013 Q2 | ||
| Summary | 0000999: When revoking an assurance in the SE console the messagebox is unclear | ||||
| Description | When you revoke an assurance as support engineer you are prompted for: "Are you sure you want to revoke this assurance" If you have quite a list of assurances you are not always sure which on is the one you just cliked. The text should be Are you sure you want to revoke the assurance with ID xxxx | ||||
| Additional Information | suggestion of change in line 354 in account/43.php onclick="return confirm('<?=_("Are you sure you want to revoke this assurance".$drow['id']."?")?>');"> | ||||
| Tags | No tags attached. | ||||
| Reviewed by | dastrath, BenBE | ||||
| Test Instructions | |||||
|
|
pushed fix to https://github.com/INOPIAE/CAcert/commit/bec7bfda8f1e6daf14c8552f29cb919d3b205d76 |
|
|
no confirm ... |
|
|
quot.patch (2,852 bytes)
diff --git a/includes/notary.inc.php b/includes/notary.inc.php
index b0e3d6b..559d534 100644
--- a/includes/notary.inc.php
+++ b/includes/notary.inc.php
@@ -319,7 +319,7 @@
<td class="DataTD" <?=$tdstyle?>> </td>
<? } else {
?>
- <td class="DataTD" <?=$tdstyle?>><?=$emopen?><a href="account.php?id=43&userid=<?=intval($userid)?>&assurance=<?=intval($assuranceid)?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID '%s'?"),$assuranceid)?>');"><?=_("Revoke")?></a><?=$emclose?></td>
+ <td class="DataTD" <?=$tdstyle?>><?=$emopen?><a href="account.php?id=43&userid=<?=intval($userid)?>&assurance=<?=intval($assuranceid)?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID "%s"?"),$assuranceid)?>');"><?=_("Revoke")?></a><?=$emclose?></td>
<?
}
}
diff --git a/pages/account/43.php b/pages/account/43.php
index ff8375d..bccaeb9 100644
--- a/pages/account/43.php
+++ b/pages/account/43.php
@@ -827,7 +827,7 @@ function showassuredto()
<td class="DataTD"><?=intval($drow['points'])?></td>
<td class="DataTD"><?=sanitizeHTML($drow['location'])?></td>
<td class="DataTD"><?=sanitizeHTML($drow['method'])?></td>
- <td class="DataTD"><a href="account.php?id=43&userid=<?=intval($drow['to'])?>&assurance=<?=intval($drow['id'])?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID '%s'?"),$drow['id'])?>');"><?=_("Revoke")?></a></td>
+ <td class="DataTD"><a href="account.php?id=43&userid=<?=intval($drow['to'])?>&assurance=<?=intval($drow['id'])?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID "%s"?"),$drow['id'])?>');"><?=_("Revoke")?></a></td>
</tr>
<? } ?>
<tr>
@@ -873,7 +873,7 @@ function showassuredby()
<td class="DataTD"><?=$drow['points']?></td>
<td class="DataTD"><?=$drow['location']?></td>
<td class="DataTD"><?=$drow['method']?></td>
- <td class="DataTD"><a href="account.php?id=43&userid=<?=$drow['from']?>&assurance=<?=$drow['id']?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID '%s'?"),$drow['id'])?>');"><?=_("Revoke")?></a></td>
+ <td class="DataTD"><a href="account.php?id=43&userid=<?=$drow['from']?>&assurance=<?=$drow['id']?>&csrf=<?=make_csrf('admdelassurance')?>" onclick="return confirm('<?=sprintf(_("Are you sure you want to revoke the assurance with ID "%s"?"),$drow['id'])?>');"><?=_("Revoke")?></a></td>
</tr>
<? } ?>
<tr>
|
|
|
push fix to https://github.com/magujs/cacert-devel/commit/4f3527d8a117f401395e3fc1ae383c12d0381dd0 apply patch file |
|
|
When revoking an assurance the confirm message: Are you sure you want to revoke the assurance with ID "xxx"? This works for show assurances given show assurances given new calculation show assurances got show assurances got new calculation =>ok |
|
|
- Are you sure you want to revoke the assurance with ID "xxxx" - Works for show assurances given show assurances given new calculation show assurances got show assurances got new calculation =>ok |
|
|
When revoking an assurance the confirmation message appears: Are you sure you want to revoke the assurance with ID "xxx"? This appears for show assurances given show assurances given new calculation show assurances got show assurances got new calculation => ok |
|
|
we have three test. please review |
|
|
The fix has been installed on the production server on June 26, 2013. See also: https://lists.cacert.org/wws/arc/cacert-systemlog/2013-06/msg00012.html |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-12-03 04:57 | INOPIAE | New Issue | |
| 2013-01-09 14:49 | Werner Dworak | Relationship added | related to 0001135 |
| 2013-05-01 09:06 | INOPIAE | Note Added: 0003947 | |
| 2013-05-01 09:06 | INOPIAE | Assigned To | => BenBE |
| 2013-05-01 09:06 | INOPIAE | Status | new => fix available |
| 2013-05-01 11:20 | BenBE | Source_changeset_attached | => cacert-devel testserver-stable 5030bbba |
| 2013-05-01 11:20 | INOPIAE | Source_changeset_attached | => cacert-devel testserver-stable bec7bfda |
| 2013-05-01 11:38 | BenBE | Reviewed by | => BenBE |
| 2013-05-01 11:38 | BenBE | Status | fix available => needs review & testing |
| 2013-05-01 11:38 | BenBE | Product Version | => 2013 Q2 |
| 2013-05-01 11:42 | MartinGummi | Note Added: 0003954 | |
| 2013-05-01 12:34 | MartinGummi | File Added: quot.patch | |
| 2013-05-01 12:36 | MartinGummi | Note Added: 0003958 | |
| 2013-05-01 12:50 | BenBE | Source_changeset_attached | => cacert-devel testserver-stable 6b97435a |
| 2013-05-01 12:50 | MartinGummi | Source_changeset_attached | => cacert-devel testserver-stable 4f3527d8 |
| 2013-05-01 13:31 | INOPIAE | Note Added: 0003963 | |
| 2013-05-01 15:05 | MartinGummi | Note Added: 0003965 | |
| 2013-05-01 16:46 | Werner Dworak | Note Added: 0003967 | |
| 2013-05-21 20:56 | INOPIAE | Note Added: 0004013 | |
| 2013-05-21 20:56 | INOPIAE | Assigned To | BenBE => NEOatNHNG |
| 2013-05-21 20:56 | INOPIAE | Status | needs review & testing => needs review |
| 2013-06-04 21:20 | BenBE | Reviewed by | BenBE => dastrath, BenBE |
| 2013-06-04 21:20 | BenBE | Assigned To | NEOatNHNG => egal |
| 2013-06-04 21:20 | BenBE | Status | needs review => ready to deploy |
| 2013-06-04 21:20 | BenBE | Product Version | 2013 Q2 => 2011 Q4 |
| 2013-06-04 21:20 | BenBE | Target Version | => 2013 Q2 |
| 2013-06-25 20:15 | BenBE | Source_changeset_attached | => cacert-devel release 87abed1d |
| 2013-06-26 13:45 | wytze | Note Added: 0004081 | |
| 2013-06-26 13:45 | wytze | Status | ready to deploy => solved? |
| 2013-06-26 13:45 | wytze | Fixed in Version | => 2013 Q2 |
| 2013-06-26 13:45 | wytze | Resolution | open => fixed |
| 2013-09-24 19:15 | INOPIAE | Status | solved? => closed |
