View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001407||CATS.cacert.org||Result Upload||public||2015-12-04 22:06||2015-12-05 01:14|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Status||needs review & testing||Resolution||open|
|Summary||0001407: Result upload should support new testserver and privacy tests|
|Description||The new testserver configuration requires the Result Upload to support SNI.|
Also, the new topic type "Data Privacy Quiz" should be supported.
|Tags||No tags attached.|
Changes proposed by felixd, plus some cosmetic changes, checked in to branch bug-1407 and merged into testserver branch.
Automatic upload should now be active on the testserver (every 5 minutes).
Additional tests and reviews would be nice, but since we're not under SM this is considered optional.
As I suggested the two hunks for the SNI support and the SQL change) I'm fine with both of them.
For your my_dir function I'd suggest using the dirname function instead, cf. http://stackoverflow.com/a/3455972
In the SQL statement beware that the additional "4" will have to match the type ID assigned to the Data Privacy category. Please verify if 4 is really the correct category ID (on the CATS).
Also, but this is separate from the functional stuff, I'd be glad if we could avoid trailing whitespace at the end of lines. No biggie, but always looks kinda wrong when having a look at the diff in Git.