View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001445 | Main CAcert Website | General | public | 2018-11-04 04:41 | 2020-05-22 11:32 |
Reporter | pmoulding@cacert.org | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | new | Resolution | open | ||
Platform | Test CAcert Website | OS | N/A | OS Version | Test |
Summary | 0001445: The code has cacert.org hardcoded. Replace with settings file. | ||||
Description | There are 2846 instances of cacert.org in the code. Some are comments and some are constants that should be moved to a configuration file. Some are straight text and should be something like the following in a .ini file. domain_name = cacert.org Some are capitalised and should be something like the following in a .ini file. domain_name_display = CAScert.org Some are email addresses and could be something like the following in a .ini file. lists_email_address = cacert-tverify@lists{domain_name} In the config file, domain name would be first then substituted into the following settings. | ||||
Steps To Reproduce | Perform a global scan for cacert.org. You will see lines like the following. $body .= "CAcert.org user\n\n"; | ||||
Additional Information | This could be added to some common code used for other things including an autoloader. I would not hold up the mysql or other issues for this change. | ||||
Tags | No tags attached. | ||||
Reviewed by | |||||
Test Instructions | |||||
Date Modified | Username | Field | Change |
---|---|---|---|
2018-11-04 04:41 | pmoulding@cacert.org | New Issue | |
2018-11-04 04:41 | pmoulding@cacert.org | Assigned To | => jandd |
2018-11-04 04:42 | pmoulding@cacert.org | Summary | The cost has cacert.org hardcoded. Replace with settings file. => The code has cacert.org hardcoded. Replace with settings file. |
2018-11-04 09:08 | jandd | Note Added: 0005651 | |
2018-11-04 09:09 | jandd | Project | Infrastructure => Main CAcert Website |
2018-11-04 09:09 | jandd | Category | general => General |
2018-11-04 09:11 | jandd | Assigned To | jandd => |
2018-11-16 10:54 | GuKKDevel | Relationship added | related to 0001449 |
2018-11-16 10:55 | GuKKDevel | Relationship replaced | has duplicate 0001449 |