|
|
Have developed corrections for Page 3, but having trouble running the web page. Still working on modifying my environment to test the fix. |
|
|
I am showing some screen shots from the current web page, and will discuss my interpretation of the request. The first picture is of the page with Advanced Options unset. The second picture is of the same page with that box checked. As I understand the request, the radio buttons below that checkbox will be eliminated leaving the text next to and below the second button. I have also reworded the note below to read: "Please note: Since you are using a certificate signed by the class 3 root...." I also moved this to above the "Advanced Options" checkbox so that it always appears. I also changed the title on the CSR textbox to remove the "Optional" word. Comments, corrections? image.png (147,106 bytes) image-2.png (126,826 bytes) |
|
|
Ad Image 1: The CSR text box with its title should be visible. Ad Image2: The "Advanced" checkbox displays/hides only the hash algorithm selection & single sign on option. Please see the pic appended. image-2-2.png (118,853 bytes) |
|
|
One more note: The selection "No name" - "Include <name>" (on both pictures) may be displayed only if the user has 50+ assurance points (APs). |
|
|
Yes, those suggested changes seem logical and in line with the request and discussions we've had. |
|
|
I'm sorry, I was unclear in my comment. I meant to respond saying that the suggestions by alkas were as I expected. The choice of signing certificate is removed, and references to it moved outside of the Advanced Options, as using Class3 should be the default and only option. And the choice to include a Name should only be available if the user also has 50+ AP. |
|
|
Yes, I understood, and that was the way that I implemented my changes, both from my memory of the original discussion and the notes above. |
|
|
I have changed the assignee to Ted, and Jan made him a reviewer of the PR. |
|
|
The code change can be found in the Webdb repository, in the "fix/bug-1550" branch. https://code.cacert.org/cacert/cacert-webdb/src/branch/fix/bug-1550 |
|
|
I added a review comment to the PR https://code.cacert.org/cacert/cacert-webdb/pulls/5. The current version of the PR contains too many unrelated changes to the deployed code version in the main branch and needs to be updated to be mergeable. |
- Anonymous
