View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000326 | Main CAcert Website | account administration | public | 2006-09-05 08:20 | 2013-01-14 20:26 |
| Reporter | Sourcerer | Assigned To | Sourcerer | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 2010 Q3 | ||||
| Summary | 0000326: searching for domain IDs | ||||
| Description | The admins should have a possibility to search for a domain by entering the domain id. This is due to abused email pings for domain adds. | ||||
| Tags | No tags attached. | ||||
| Reviewed by | |||||
| Test Instructions | |||||
|
|
Searching for domain ids is possible by entering the number in the domain search field. The result page gives both the personal and the organisational domain with that ID. |
|
|
We should add the domain id in the display |
|
2010-07-08 09:31
|
49.patch (2,665 bytes)
--- 49.php.orig 2010-07-08 09:59:13.000000000 +0200
+++ 49.php 2010-07-07 13:38:46.000000000 +0200
@@ -24,7 +24,7 @@
$domainsearch = "%$domain%";
if(preg_match("/^\d+$/",$domain))
$domainsearch = "";
- $query = "select `users`.`id` as `id`, `domains`.`domain` as `domain` from `users`,`domains`
+ $query = "select `users`.`id` as `id`, `domains`.`domain` as `domain`, `domains`.`id`as `domid` from `users`,`domains`
where `users`.`id`=`domains`.`memid` and
(`domains`.`domain` like '$domainsearch' or `domains`.`id`='$domain') and
`domains`.`deleted`=0 and `users`.`deleted`=0 and
@@ -41,15 +41,16 @@
{ ?>
<tr>
<td class="DataTD"><?=_("Domain")?>:</td>
+ <td class="DataTD"><?=$row['domid']?></td>
<td class="DataTD"><a href="account.php?id=43&userid=<?=$row['id']?>"><?=sanitizeHTML($row['domain'])?></a></td>
</tr>
<? } if(mysql_num_rows($res) >= 100) { ?>
<tr>
- <td class="DataTD" colspan="2"><?=_("Only the first 100 rows are displayed.")?></td>
+ <td class="DataTD" colspan="3"><?=_("Only the first 100 rows are displayed.")?></td>
</tr>
<? } else { ?>
<tr>
- <td class="DataTD" colspan="2"><? printf(_("%s rows displayed."), mysql_num_rows($res)); ?></td>
+ <td class="DataTD" colspan="3"><? printf(_("%s rows displayed."), mysql_num_rows($res)); ?></td>
</tr>
<? } ?>
</table><br><br>
@@ -60,7 +61,7 @@
printf(_("No personal domains found matching %s"), sanitizeHTML($domain));
}
- $query = "select `orgid`,`domain` from `orgdomains` where `domain` like '$domainsearch' or `id`='$domain' limit 100";
+ $query = "select `orgid`,`domain`,`id` from `orgdomains` where `domain` like '$domainsearch' or `id`='$domain' limit 100";
$res = mysql_query($query);
if(mysql_num_rows($res) >= 1) { ?>
<table align="center" valign="middle" border="0" cellspacing="0" cellpadding="0" class="wrapper">
@@ -72,15 +73,16 @@
{ ?>
<tr>
<td class="DataTD"><?=_("Domain")?>:</td>
+ <td class="DataTD"><?=$row['id']?></td>
<td class="DataTD"><a href="account.php?id=26&orgid=<?=intval($row['orgid'])?>"><?=sanitizeHTML($row['domain'])?></a></td>
</tr>
<? } if(mysql_num_rows($res) >= 100) { ?>
<tr>
- <td class="DataTD" colspan="2"><?=_("Only the first 100 rows are displayed.")?></td>
+ <td class="DataTD" colspan="3"><?=_("Only the first 100 rows are displayed.")?></td>
</tr>
<? } else { ?>
<tr>
- <td class="DataTD" colspan="2"><? printf(_("%s rows displayed."), mysql_num_rows($res)); ?></td>
+ <td class="DataTD" colspan="3"><? printf(_("%s rows displayed."), mysql_num_rows($res)); ?></td>
</tr>
<? } ?>
</table><br><br>
|
|
|
Patch just adds ID to SQL queries and to the resulting HTML tables. Ok to be migrated to productional system. |
|
|
Patch has been applied in production. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-09-05 08:20 | Sourcerer | New Issue | |
| 2006-09-05 08:20 | Sourcerer | Status | new => needs work |
| 2006-09-05 08:20 | Sourcerer | Assigned To | => duane |
| 2007-06-25 08:02 | evaldo | Assigned To | duane => |
| 2007-06-25 08:08 | evaldo | Status | needs work => @30@ |
| 2007-06-25 08:08 | evaldo | Projection | none => tweak |
| 2010-07-07 15:16 | Sourcerer | Note Added: 0001591 | |
| 2010-07-07 15:16 | Sourcerer | Status | @30@ => closed |
| 2010-07-07 15:16 | Sourcerer | Resolution | open => fixed |
| 2010-07-07 15:16 | Sourcerer | Assigned To | => Sourcerer |
| 2010-07-08 09:31 | Sourcerer | Note Added: 0001593 | |
| 2010-07-08 09:31 | Sourcerer | Status | closed => needs feedback |
| 2010-07-08 09:31 | Sourcerer | Resolution | fixed => reopened |
| 2010-07-08 09:31 | Sourcerer | File Added: 49.patch | |
| 2010-07-27 18:44 | Sourcerer | View Status | private => public |
| 2010-08-04 11:05 | edgarwahn | Note Added: 0001612 | |
| 2010-08-04 11:05 | edgarwahn | Status | needs feedback => confirmed |
| 2010-08-05 10:42 | Sourcerer | Note Added: 0001617 | |
| 2010-08-05 10:42 | Sourcerer | Status | confirmed => solved? |
| 2010-08-05 12:49 | Sourcerer | Status | solved? => closed |
| 2010-08-05 12:49 | Sourcerer | Resolution | reopened => fixed |
| 2013-01-14 20:26 | Werner Dworak | Fixed in Version | => 2010 Q3 |
