View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000817 | Main CAcert Website | account administration | public | 2010-04-27 22:29 | 2013-01-15 14:34 |
| Reporter | jhf2442 | Assigned To | Sourcerer | ||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 2010 Q2 | ||||
| Summary | 0000817: Whois parser issues when listing ping emails for domain add | ||||
| Description | When adding a domain, a whois query is run and its output parsed. Looks like some domains are missing a blank between field name and email-address, leading to nonsense email addresses being listed. Example : "Registrant-Email:lorenz.leutgeb@gmail.com" (domain=krytux.net) This is no general problem with .net domains, maybe it's only one registrar who's using this bad syntax | ||||
| Additional Information | Problem is located in includes/account.php near line 492. A test should be added inside the foreach loop to split using ":" as delimiter and then check for "@" inside the string. No idea however what side effects are introduced by this | ||||
| Tags | No tags attached. | ||||
| Attached Files | account.patch (389 bytes)
--- account.php 2009-12-20 23:41:38.000000000 +0100
+++ account.php.orig 2010-05-01 18:50:28.000000000 +0200
@@ -488,6 +488,7 @@
$line = trim(str_replace("\t", " ", $line));
$line = trim(str_replace("(", "", $line));
$line = trim(str_replace(")", " ", $line));
+ $line = trim(str_replace(":", " ", $line));
$bits = explode(" ", $line);
foreach($bits as $bit)
| ||||
| Reviewed by | |||||
| Test Instructions | |||||
|
|
Please review the account.patch |
|
|
Looks fine for me, : is not expected to be used in an email-address, so the replacement should not break any email |
|
|
Looks ok, imported to cacert-devel.git (commit 919d148bf8c0488cecbbe885c7e4a9362bca354b). git://cacert-git.it-sls.de/cacert-devel.git Checked out to cacert1.it-sls.de (test system). |
|
|
Patch has been implemented. Please test and close the bug. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-04-27 22:29 | jhf2442 | New Issue | |
| 2010-05-01 16:51 | Sourcerer | File Added: account.patch | |
| 2010-05-01 16:51 | Sourcerer | Note Added: 0001581 | |
| 2010-05-01 17:06 | jhf2442 | Note Added: 0001582 | |
| 2010-05-03 07:18 | edgarwahn | Note Added: 0001583 | |
| 2010-05-04 19:52 | Sourcerer | Note Added: 0001584 | |
| 2010-05-04 19:52 | Sourcerer | Status | new => solved? |
| 2010-05-12 13:59 | Sourcerer | Status | solved? => closed |
| 2010-05-12 13:59 | Sourcerer | Resolution | open => fixed |
| 2010-05-12 13:59 | Sourcerer | Assigned To | => Sourcerer |
| 2013-01-15 14:34 | Werner Dworak | Fixed in Version | => 2010 Q2 |
